Plugin crashes server when generating a new chunk

selabie68 · May 6, 2018, 1:46am

I have developed a new plugin, it works fine in a chunk that is already generated but if I try to move to a new chunk it crashes the server.

I can’t see anything in the server crash log that points to anything specific.

My server crash log: server-crash-log - Pastebin.com

My plugin code: GitHub - selabie68/OreGenUltimateSponge: Plugin for Minecraft Sponge Servers that generates ore when lava meets water. For example, in a cobblestone generator.

JBYoshi · May 6, 2018, 1:56am

Description: Watching Server

This means that something going on during the game loop is taking too long to run. The stack trace is supposed to help; it seems to be in the middle of yelling about some other error. Are there any other logs available?

d4rkfly3r · May 6, 2018, 2:03am

Also just out of curiosity, is this running on top of an NFS server?

selabie68 · May 6, 2018, 2:16am

The logs from the console created a large output file >300MB. It seems to just be a repeat of the same error. I have created file of what seems like the most relevant lines.

selabie68 · May 6, 2018, 2:17am

No NFS services running. It is just running on my iMac as a test server for my development environment.

selabie68 · May 11, 2018, 1:20am

@JBYoshi Could the issue be with my listener? I was unable to find an appropriate filter so I am simply listening to all ChangeBlockEvent.Modify events, this could be too much for generating new chunks?

github.com

selabie68/OreGenUltimateSponge/blob/master/src/main/java/io/github/selabie68/listeners/BlockListener.java#L53-L65


@Listener
public void onCobbleGen(ChangeBlockEvent.Modify e) {
    BlockSnapshot bto = e.getTransactions().get(0).getOriginal();
    boolean isLiquidMix = e.getContext().containsKey(EventContextKeys.LIQUID_MIX);
    if (isLiquidMix && bto.getLocation().isPresent() && bto.getState().getType() == BlockTypes.FLOWING_LAVA) {
        e.setCancelled(true);
        Location<World> ourBlock = bto.getLocation().get();
        BlockType newBlock = this.randomiser.next();
        OreGenUltimate.get().logger.info("We generated: " + newBlock.getName());
        ourBlock.setBlockType(newBlock);
    }
}

JBYoshi · May 11, 2018, 9:19pm

Probably. Instead of using ourBlock.setBlockType(), use Transaction.setFinal() to change the final block:

Transaction<BlockSnapshot> transaction = e.getTransactions().get(0);
BlockSnapshot bto = transaction.getOriginal();
// ...
transaction.setFinal(transaction.getFinal().withState(this.randomiser.next().getDefaultState());

Not sure why it isn’t simply throwing a StackOverflowError, but whatever it is, this should fix it.

selabie68 · May 11, 2018, 11:16pm

These changes break the functionality of the plugin. i.e it is not replacing the blocks and always creates cobble.

I did use the Transaction.setCustom() method as this appeared to be the method to use and I did not have the Transaction.setFinal() method.

I am using org.spongepowered:spongeapi:7.0.0 in my gradle build